search

dobromir-hristov / vuecommunity

Vue.js community and ecosystem guide, written and maintained by the community itself
https://vue-community.org
167 stars 82 forks source link

Missing logo in metadata for individual chapters #141

Closed gustojs closed 4 years ago

gustojs commented 4 years ago

It would be lovely to have the logo show up when we link to chapters on social media or chat platforms. This is how it works at the moment.

https://twitter.com/gustojs/status/1263486612392075271

gnclmorais commented 4 years ago

I would like to take this one, I’d love to start helping around a bit. 🙋‍♂️

dobromir-hristov commented 4 years ago

This is already added, donno whats wrong - https://github.com/dobromir-hristov/vuecommunity/blob/master/docs/.vuepress/config.js#L138-L139

gnclmorais commented 4 years ago

Interesting, Twitter’s card validator seems to show that everything’s good: image

dobromir-hristov commented 4 years ago

Because I just fixed it :)

gnclmorais commented 4 years ago

✔️ Test tweet right now: image

Nice one, @dobromir-hristov!

gustojs commented 4 years ago

Thanks. <3