search

dobtco / beacon

[Not maintained] Beacon, originally built by CfA Pittsburgh 2015.
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Clarify email #25

Closed alizauf closed 8 years ago

alizauf commented 8 years ago

I added language to flash messages and email so that vendors who follow specific opportunities are prompted to sign up for the newsletter. This was in reference to #1

ajb commented 8 years ago

@alizauf: I added some comments to this PR for changes that should be made before it gets merged. You can checkout this branch (clarify-email), and any commits you push will be appended to this PR. Once you're done, write a comment to let me know, and I'll review it again.

Also, it looks like there's a test (test_signup_for_opportunity) that's failing.

alizauf commented 8 years ago

Cool I'll make these changes. Thanks.

alizauf commented 8 years ago

I think that test is failing due to the new added link--I'll work on that.

alizauf commented 8 years ago

Okay, I believe I fixed all of these. I added Markup to the tests since it is used in the flashes, but I'm not sure if that will cause issues with the tests. Is there a way for me to run the tests locally?

ajb commented 8 years ago

https://github.com/dobtco/beacon#testing

alizauf commented 8 years ago

Ah, yep, that was right there.

ajb commented 8 years ago

Looks great. Merged!