dobtco / beacon

[Not maintained] Beacon, originally built by CfA Pittsburgh 2015.
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Question & Answer section #4

Closed ajb closed 8 years ago

ajb commented 8 years ago

Frontend mockups: http://big-ideas-prototype.dobt.co/opportunity/#new_question Backend mockups: http://big-ideas-prototype.dobt.co/admin/opportunity/qa/

Rough acceptance criteria:

bsmithgall commented 8 years ago

I guess questions will be associated with an email account?

ajb commented 8 years ago

Yeah... maybe it makes sense to make some UI tweaks that emphasize the fact that "Subscribe to opportunities" is really the same thing as creating an account -- albeit that you only need an email to sign up.

Kinda ties into #6.

ajb commented 8 years ago

Alternatively, if we allow vendors to sign up for user accounts ( #6), this would kinda answer itself.

bsmithgall commented 8 years ago

@ajb quick gut check, am I missing anything obvious with this quick schema mockup?

mockup

All models have basic status about when they are created, who created them, etc.

A few questions:

  1. Who has permissions to answer questions and edit answers? Is it the same people who can edit an opportunity, or anyone with a 'staff' role?
  2. Can questions be edited after asking (my bet is on no unless we do something like forcing vendors to sign up for accounts and/or making them re-auth as in #6)
ajb commented 8 years ago

Schema looks solid. When I've implemented this feature before I've just kept the question and the answer in the same table, but I'm :+1: on whatever is idiomatic here.

Is it the same people who can edit an opportunity

Yup. (Had to look at the code to make sure I understood these permissions... nice docs!)

Can questions be edited after asking (my bet is on no unless we do something like forcing vendors to sign up for accounts and/or making them re-auth as in #6)

Let's say no for now -- it's too weird if a vendor edits a question after it's already been asked, and the administrators have already received an email notification with the question text.

However, if we implement #6, I think that vendors should be able to delete their own questions, provided that they have not been answered yet. This effectively gives them the ability to edit... just delete and create a new one.

bsmithgall commented 8 years ago

I guess a question will only ever have one answer right? In that case it makes sense to just merge the schema. I'll update the drawing.

ajb commented 8 years ago

Sounds good!

On Wed, Jan 27, 2016 at 6:27 PM, Ben Smithgall notifications@github.com wrote:

I guess a question will only ever have one answer right? In that case it makes sense to just merge the schema. I'll update the drawing.

— Reply to this email directly or view it on GitHub https://github.com/dobtco/beacon/issues/4#issuecomment-175909377.

Adam Becker (951) 9-BECKER @AdamJacobBecker

bsmithgall commented 8 years ago

Who gets notified when a question is asked? I feel like notifying all admins for all questions is a bit overkill. Maybe the opportunity creator and the opportunity contact?

For answers, I was thinking the opportunity creator, contact, vendor who asked the question, and any vendors following the opportunity.

Thoughts?

Progress is happening over in the questions-and-answers branch. Here's some screenshots

screen shot 2016-01-28 at 4 28 07 pm screen shot 2016-01-28 at 4 28 51 pm screen shot 2016-01-28 at 4 29 08 pm

ajb commented 8 years ago

I feel like notifying all admins for all questions is a bit overkill. Maybe the opportunity creator and the opportunity contact?

Perfect.

For answers, I was thinking the opportunity creator, contact, vendor who asked the question, and any vendors following the opportunity.

I agree with all of the above except I'm not sure about "any vendors following the opportunity". Take the Big Ideas PHL live site, for example: http://bigideasphl.com/2015/12/15/seeking-proposals-to-improvereplace-the-big-ideas-phl-website/. That would have been a lot of notifications, and getting notifications on other peoples' questions makes you more likely to miss a notification that your own question has been answered. Does that make sense? I'm not entirely sure myself.

bsmithgall commented 8 years ago

I'm struggling a bit with email copy for the "answer" email. If it's only going to the vendor who asked the question it's pretty straightforward (your question on Beacon was answered), but if it's going to multiple it's a bit more complicated.

ajb commented 8 years ago

No worries. Feel free to leave as a placeholder and we can discuss in the PR. (And we can loop Josh in, too.)

On Thu, Jan 28, 2016 at 10:36 PM, Ben Smithgall notifications@github.com wrote:

I'm struggling a bit with email copy for the "answer" email. If it's only going to the vendor who asked the question it's pretty straightforward (your question on Beacon was answered), but if it's going to multiple it's a bit more complicated.

— Reply to this email directly or view it on GitHub https://github.com/dobtco/beacon/issues/4#issuecomment-176555056.

Adam Becker (951) 9-BECKER @AdamJacobBecker