search

dobtco / bootstrap-accessible

Sleek, intuitive, and powerful front-end framework for faster and easier web development.
http://twbs.github.io/bootstrap/
Apache License 2.0
6 stars 1 forks source link

Toggle buttons must have title attribute #4

Closed ajb closed 11 years ago

ajb commented 11 years ago

the navbar toggle button (on mobile) is a good example of this occurring.

ajb commented 11 years ago

contradicts http://a11yproject.com/posts/title-attributes/

maybe there's a better solution?

criscristina commented 11 years ago

Does that mean this isn't an issue? "For screen reader users the content included inside of the title attribute is typically unncessary, redundant, and possibly not even used."

ajb commented 11 years ago

Actually -- only an issue for buttons with no text content. (Like the navbar-toggle button.)

I've updated the markup to look like this:

    <button class="navbar-toggle" type="button" data-toggle="collapse" data-target=".bs-navbar-collapse">
      <span class="visually-hidden">Expand Navigation</span>
      <span class="icon-bar"></span>
      <span class="icon-bar"></span>
      <span class="icon-bar"></span>
    </button>