Increase dropdown default min-width

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Increase dropdown default min-width #11

Closed ajb closed 9 years ago

ajb commented 9 years ago

Shouldn't this dropdown extend to take up more width? Or should the developer explicitly set a width in CSS if they want a dropdown that's wider than the current 140px?

jrubenoff commented 9 years ago

You should explicitly set a width for this.

ajb commented 9 years ago

What do you think of letting dropdowns expand up to something a little wider than the current min-width: 160px? max-width: 250px or something? I'm having trouble understanding the behavior of the current CSS actually, and why it's not acting like this already.

jrubenoff commented 9 years ago

Yeah, I think we just need to set the width manually if we want to have dropdowns containing options where the text wraps. Otherwise, the min-width just behaves like a width property.

ajb commented 9 years ago

K, sounds alright. Can we increase it a bit? 140px is small, if that's what it currently is.

jrubenoff commented 9 years ago

Sure... it's 160 now, how about 220?

ajb commented 9 years ago

Sounds good.

On Wed, Jan 7, 2015 at 1:18 PM, Josh Rubenoff notifications@github.com wrote:

Sure... it's 160 now, how about 220?

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/issues/11#issuecomment-69093764.

Adam Becker 510.928.9111 @AdamJacobBecker