dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

add regression testing specs #123

Closed ajb closed 9 years ago

ajb commented 9 years ago

cf #113.

See https://github.com/ronen/rspec-page-regression for more.

I think this is handy to have, especially for interactive bits. I would consider adding regression specs for:

ajb commented 9 years ago

@jrubenoff: curious to hear your thoughts on this.

jrubenoff commented 9 years ago

Seems :+1: to try out, at least.

jrubenoff commented 9 years ago

Just realized Github doesn't allow comments on images, so, one qualifier: assuming expected.png is automatically generated, it doesn't appear to be loading Typekit fonts.

Something to keep in mind if tests are generating screenshots that look "broken", even when the style guide is fine.

ajb commented 9 years ago

Yeah, so the dummy app runs on the example.com host, which we need to whitelist for Typekit.

Also, I've gotta figure out why the specs are failing before this can get merged.