dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Page subheader bug fix #139

Closed aviv closed 9 years ago

aviv commented 9 years ago

closes https://github.com/dobtco/screendoor-v2/issues/2241 merge with https://github.com/dobtco/screendoor-v2/pull/2287

jrubenoff commented 9 years ago

This changes our existing styles for page subheaders:

screen shot 2015-07-27 at 2 01 24 pm

We need a new pattern for the lock icon.

ajb commented 9 years ago

Alternatively, we could just remove the icon_private component entirely, unless we think it's really necessary to have? I mean, it's kinda redundant, there's a lot of things in Screendoor that are "visible only to collaborators with appropriate permissions", yet don't have an icon_private next to them.

aviv commented 9 years ago

Yep, I actually agree. Doesn't seem necessary, at least here. Not sure if there's anywhere else where it's more relevant/necessary.

ajb commented 9 years ago

You could grep for it?

jrubenoff commented 9 years ago

:+1: