Add CSS animations test and conditional loading to Modernizr

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Add CSS animations test and conditional loading to Modernizr #148

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

Required for dobtco/screendoor-v2#2368

ajb commented 9 years ago

Looks like you added a lot more than just cssanimations:

Can you tell me why you need Modernizr.load?

jrubenoff commented 9 years ago

I did add the shiv as well, you're right. Not sure why we didn't have that before.

Everything else comes with Modernizr.load.

Can you tell me why you need Modernizr.load?

See dobtco/screendoor-v2#2368

ajb commented 9 years ago

We're loading the shiv separately. AFAICT Modernizr.load can be replaced with and if statement and $.getScript. Let's chat about this and screendoor-v2#2368 later today or tomorrow.

jrubenoff commented 9 years ago

Just removed the shiv.

Modernizr.load also contains nope and complete options, which I will want to use going forward.