search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Blank options in dropdowns shouldn't display as blank #153

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

Blank options currently appear like this:

screen shot 2015-08-18 at 4 10 35 pm

We should add placeholder text:

screen shot 2015-08-18 at 4 11 40 pm

ajb commented 9 years ago

This is just a matter of markup. You could change include_blank: true to include_blank: "None selected": https://github.com/dobtco/dvl-core/blob/3ead2744bbeccf7713279defb9ffe808ddcef218/spec/dummy/app/views/home/forms.rb#L58

jrubenoff commented 9 years ago

The placeholder text for the dropdown ("Choose an option") should be different than the blank value ("None selected"). Also, I'd like to add a class to the blank option if possible, so I can make the text lighter. include_blank values don't offer that.

ajb commented 9 years ago

Gotcha. I didn't realize that we were talking about rich-text droptowns. Marking as ready :D