search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Improved page header styles #161

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

Also easier for those with color blindness to understand which link is active.

screen shot 2015-09-08 at 10 18 46 am

ajb commented 9 years ago

Does this address #136 and #144? If not, can it?

jrubenoff commented 9 years ago

Thanks for pointing those out! Fixed #136 and commented on #144. Still need to modify Screendoor accordingly, though.

ajb commented 9 years ago

Awesome, looks great. Just pulled it down and have one comment, which is that the .active text is a bit light for my liking. What do you think of using $bodyFontColor instead of $primaryColor? Or maybe making it bold?

img

jrubenoff commented 9 years ago

I like how it looks in Screendoor, so I just added a darker primary color to dvl-core instead.

ajb commented 9 years ago

I don't think we should be using $primaryColor for typography -- think about how it would look on Autodrip where the brand color is #513847. (purple)

I'm gonna make that change, but I'll wait for your :+1: before merging.

jrubenoff commented 9 years ago

I want the selected state to be a darker shade of blue, so I just added it as a variable: $linkSelectedColor. Does that work?

ajb commented 9 years ago

:ok_hand: