search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Better selects #22

Closed ajb closed 9 years ago

ajb commented 9 years ago

@jrubenoff: here's the JS for the styled selects. Note that I've commented out everything to do with the width option, because I didn't want to pre-determine how you'll implement that. However, it's worth noting that in our current implementation, we have options for setting the width of the select at full, auto, or [X]px, and I'm pretty sure we're using each of those options.

We should aim to use the existing dropdown styles here, right?

This should also be easier now that I've updated the preview app to use Rails. Hoorah!

ajb commented 9 years ago

Closes #20

jrubenoff commented 9 years ago

Done. Are you looking to replace .select_wrapper entirely? If so, are you handling the migration on Screendoor or should I?

ajb commented 9 years ago

Currently, StyledSelect is a javascript component inside of Screendoor that uses the .select_wrapper class. This PR will a) move these to dvl-core, and b) rename the class name to styled_select_wrapper. Does that clear things up?

  1. Can you address the width issue?
  2. I'll handle the migration inside of Screendoor.
jrubenoff commented 9 years ago

You can add the .auto or .full classes to .styled_select_wrapper, or set a width with an inline style.

ajb commented 9 years ago

@jrubenoff: can you look again, and browser test too? all of the relevant use cases should now be covered in the preview.

jrubenoff commented 9 years ago

Looks good in Safari / Chrome / FF, will download an IE9 VM and test by sometime tomorrow night.

ajb commented 9 years ago

Why don't you use Browserstack? If you need help getting it setup, we can do it today.

On Wed, Jan 7, 2015 at 10:31 PM, Josh Rubenoff notifications@github.com wrote:

Looks good in Safari / Chrome / FF, will download an IE9 VM and test by sometime tomorrow night.

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/pull/22#issuecomment-69141533.

Adam Becker 510.928.9111 @AdamJacobBecker

ajb commented 9 years ago

I would also recommend BrowserStack's screenshots feature -- I'll post an example on the checkboxes/radio thread.

Also, assuming that our goal is to make the regular <select> and the dropdown_select look the same, one potential issue is that the dropdown_select doesn't have an focus state -- I'm not sure if that's possible to achieve or not.

jrubenoff commented 9 years ago

Ah, I had no idea they let you test locally... thanks!

jrubenoff commented 9 years ago

Alrighty, should be good to go.