dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Remove all utility classes, redesigned `.filter_form` #236

Closed jrubenoff closed 8 years ago

jrubenoff commented 8 years ago

Remove all utility classes from shame.scss.

This task involved creating a more streamlined look for .filter_form:

screen shot 2016-02-18 at 6 01 18 pm

There are also a few minor styling fixes and additions, like left-aligning dropdown text within .sidebar_sub_actions.)

ajb commented 8 years ago

Nice, glad that we're finally getting this done.

Added some comments inline. Also:

img

img

img

jrubenoff commented 8 years ago

I don't think we need to add a max-width to .filter_form. We might want full- or half-width search bars, for instance, depending on the needs of the app.

Addressed all of your comments, save for the .sidebar_box thing.

ajb commented 8 years ago

Not sure where to put this comment, but I'm not totally satisfied with the new filter form design when there are multiple inputs, like in https://github.com/dobtco/platform/pull/497.

Here's another example from Autodrip:

img

What do you think of redesigning https://github.com/dobtco/platform/pull/497 so all the inputs fit on one line?

jrubenoff commented 8 years ago

It's not really the same component. My main priority there was to avoid writing a ton of .filter_form style overrides for something users will never see. FWIW, I like how it visually separates the filters from the primary input. Helpful on the DOBT admin orgs page, to distinguish the selectize from the selects.

But I also don't really care. We could convert all of them to .dropdown_rows if you want:

screen shot 2016-02-19 at 10 22 02 am

ajb commented 8 years ago

What do you mean by dropdown_rows?

ajb commented 8 years ago

Ah, nm, I see in https://github.com/dobtco/platform/pull/497/files

ajb commented 8 years ago

:+1: :+1: :+1:

ajb commented 8 years ago

We're redesigning the "Your plan" page so this doesn't really matter, but here's what this change did to it:

img

How can we be sure this bug wasn't triggered elsewhere?

jrubenoff commented 8 years ago

This is desired behavior... the input should take up the full content area unless we tell it otherwise.

It looks a little weird on the Your plan page, but that's because that page's layout is rough in the first place. Hence dobtco/screendoor-v2#3289