Add fieldset pattern

[jrubenoff]

Closes #234

To-do:

• [ ] Convert date picker to a fieldset
  • [ ] Add Choose a date and Choose a time labels to date picker, and hide them with @include hidden

[ajb]

Is the "to do" for me?

Also, I would strongly recommend using either a generic utility class (.hidden), or a form-scoped utility class (.form_label_hidden) instead of scattering @include hidden everywhere... it'll save us a ton of bytes.

[jrubenoff]

The to-do is for you; wasn't sure how to add it myself.

.form_label_hidden sounds good.

Also would like your :+1: on the implementation. It's a little awkward from an i18n perspective, but this comment gives the impression that there's no better approach... :confused:

[ajb]

Sorry this is still sitting. I want to get to it, but the implementation needs to change pretty much wholesale, in order to work properly with simple_form.

If you can answer my Q's inline about the CSS, that will help me figure out how to properly implement it.

[jrubenoff]

Alright, I'm fine with whatever implementation you decide as long as the markup and CSS classes remain roughly the same.

If we have to choose one, I am strongly biased towards semantics / accessibility over developer efficiency.

[ajb]

If we have to choose one, I am strongly biased towards semantics / accessibility over developer efficiency.

I would not like to sacrifice either for the other.

[ajb]

Closed by #251.