search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Add microcopy styles, add to style guide #245

Closed jrubenoff closed 8 years ago

jrubenoff commented 8 years ago

Required for dobtco/screendoor-v2#3272

ajb commented 8 years ago

Looks good. I'm gonna move the preview to the /forms page, since that's where the scss lives.

ajb commented 8 years ago

Actually, there was already a microcopy component on the /forms page, so I fixed that.

Can you help clarify for me... what's the intended markup for microcopy? Is it:

div(class: 'microcopy') {
  p 'foo'
}

or

div(class: 'microcopy') {
  p 'foo'
  a 'bar', class: 'button small'
}

or

div(class: 'microcopy') {
  span 'foo'
}

The CSS is a bit confusing, or is it just crufty?

jrubenoff commented 8 years ago

Removed some unused styles. You can have no markup in there (like in the dashboard), or a p tag with an optional button at the bottom.

On Thu, Mar 3, 2016 at 5:03 PM, Adam Becker notifications@github.com wrote:

Assigned #245 https://github.com/dobtco/dvl-core/pull/245 to @jrubenoff https://github.com/jrubenoff.

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/pull/245#event-577123056.

ajb commented 8 years ago

:+1: Thanks!