fix horizontal legends - Githubissues

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Closed ajb closed 8 years ago

ajb commented 8 years ago

@jrubenoff: can you confirm that this is the correct fix?

ajb commented 8 years ago

Might need some browser fixes, too. Here's IE9:

jrubenoff commented 8 years ago

Can you clarify why this fix is needed?

I changed the way we're fixing this... we don't need to add a float here.

ajb commented 8 years ago

Here's why the fix is needed:

This is with your latest commits. I can't figure out how to fix...

jrubenoff commented 8 years ago

I think IE9 setstext-align by default for legends... just fixed.

ajb commented 8 years ago

Still looks like this in latest Safari on OS X:

ajb commented 8 years ago

Added the float back, which fixes Safari.

Tested on Chrome, Safari, FF on my mac.

Tested on a whole bunch of devices on Browserstack using their screenshots feature: https://www.browserstack.com/screenshots/281c7cf17cf2c4fdd68e826df03df66f94bf81f7

With this amount of testing, I'm comfortable merging.