Color contrast fixes - Githubissues

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Color contrast fixes #256

Closed jrubenoff closed 8 years ago

jrubenoff commented 8 years ago

The only noticeable changes here are really:

Also:

Added $primaryColorText, $successColorText, etc. variables, to 1) provide the correct contrast ratio depending on the UI color and 2) allow us to set the contrast appropriately if we override UI colors in new applications
Removed $darkGray and $gray text, where it existed
Improved contrast ratios for disabled states

ajb commented 8 years ago

Looks great.

I used HTML_CodeSniffer to check for any remaining contrast issues. It found a bunch of false positives, but I think these are valid:

There are also two areas that I think could look better, but I understand if it's too hard to find something better that still provides enough contrast.

[ ] The error color is very pink, especially in this context: http://take.ms/WY6LA
[ ] The yellow for warning labels looks dirty: http://take.ms/0EOKW

jrubenoff commented 8 years ago

Just fixed the issues in your screenshots.

Re: the two issues you mentioned, I had a hard time finding better, high-contrast colors. I agree with you re: the warning yellow, but we don't currently use it anywhere.