dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Find a new "primary" button color that works with light text #257

Closed ajb closed 8 years ago

ajb commented 8 years ago

Still think this looks kinda weird:

img

jrubenoff commented 8 years ago

How about this? (#5E708A)

screen shot 2016-04-20 at 4 36 21 pm
ajb commented 8 years ago

Yeah, I've always been confused about the info vs primary buttons anyway. (I can take responsibility for creating this confusion, too!) And currently, our primary button does not match our "primary" color: http://take.ms/93hWr

So while we're on the subject, I'm all for making our button patterns easier to understand for developers. What's the point again of having info and primary buttons? Just to provide some variety?

And I like your mockup, although the font weights seem different, which is weird. Is there some smoothing going on?

jrubenoff commented 8 years ago

The $primaryColor should differ across applications... it changes according to the app's brand color.

It's probably best to rename the buttons to primary and secondary.

ajb commented 8 years ago

It's probably best to rename the buttons to primary and secondary.

:+1:. If you want to PR something that looks like your mockup, I think that would be major improvement!