dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

bring rich dropdown elements into focus when opening #281

Closed ajb closed 8 years ago

ajb commented 8 years ago

cf #248

@jrubenoff, I could use your opinion here. (Once you're back!)

Here's a screencast: http://take.ms/hpwPH

jrubenoff commented 8 years ago

What if we just positioned the dropdown menu above the button in these instances, instead of below it?

screen shot 2016-07-11 at 2 01 34 pm

This would more closely replicate the behavior of existing selects, and remove the abrupt / awkward shift in page position that this approach requires.

ajb commented 8 years ago

That would be about 100x more complicated to implement. If this is an improvement, we should merge it -- if not, I don't really have any other options. (I worked at this for a while...)

jrubenoff commented 8 years ago

Well, just looked at the original issue, which clarifies things a bit!

So...

ajb commented 8 years ago

Please look at the implementation. There is no flexibility on how it behaves.

jrubenoff commented 8 years ago

Couldn't you..

ajb commented 8 years ago

I tried that, but I was having trouble figuring out how to get the correct offset of li.active a. Also, there's no guarantee where it will be positioned once it's .focus()ed.

If you'd like to pair on this, we can try, but I spent a while trying to make this work.

ajb commented 8 years ago

In person: we went over my comment above ^^.