Closed ajb closed 8 years ago
What if we just positioned the dropdown menu above the button in these instances, instead of below it?
This would more closely replicate the behavior of existing select
s, and remove the abrupt / awkward shift in page position that this approach requires.
That would be about 100x more complicated to implement. If this is an improvement, we should merge it -- if not, I don't really have any other options. (I worked at this for a while...)
Well, just looked at the original issue, which clarifies things a bit!
So...
Re: the bottom-of-viewport stuff, what I suggested above is how iOS does it. You can see another manifestation of the same problem in #129. Right now, it looks like it's a "won't fix" Bootstrap issue (see this, and fat's comment that this might be a perf problem.)
We should keep thinking about ways to solve this in the future, beyond this issue... it's still pretty annoying for responsive design, and for smaller screens.
Please look at the implementation. There is no flexibility on how it behaves.
Couldn't you..
$.scrolltop
of .dropdown
to li.active a
I tried that, but I was having trouble figuring out how to get the correct offset of li.active a
. Also, there's no guarantee where it will be positioned once it's .focus()
ed.
If you'd like to pair on this, we can try, but I spent a while trying to make this work.
In person: we went over my comment above ^^.
cf #248
@jrubenoff, I could use your opinion here. (Once you're back!)
Here's a screencast: http://take.ms/hpwPH