search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Message preview header doesn't handle blank <dd>s properly #286

Closed ajb closed 8 years ago

ajb commented 8 years ago

img

jrubenoff commented 8 years ago

Putting an &nbsp; in there might solve it?

ajb commented 8 years ago

Probably. But should this not be fixed in the CSS?

On Mon, Sep 19, 2016 at 10:19 AM, Josh Rubenoff notifications@github.com wrote:

Putting an   in there might solve it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dobtco/dvl-core/issues/286#issuecomment-248058552, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNiLVogzRL7uIsh9kPU-1OYjZVQq1Nxks5qrsQfgaJpZM4KAuJr .

Adam Becker (951) 9-BECKER @AdamJacobBecker

jrubenoff commented 8 years ago

Sorry, glanced at this briefly. I actually have a related issue on this I've been meaning to write up.

We should never let the above state happen. Instead, we should have a "blank" or "error" state for each field in the message preview. (i.e. "No recipient", or "Please add a recipient.")

I can add a sentence to the style guide that specifies this.

ajb commented 8 years ago

:+1: