Adjust dropdown height and positioning

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Adjust dropdown height and positioning #304

Closed jrubenoff closed 7 years ago

jrubenoff commented 7 years ago

From dobtco/tasks-josh#24

Fixes the max dropdown height so that it cuts off in the middle of a list item, indicating that the user can scroll to view more options.

Also adds a bit of spacing between the dropdown click target and menu.

dropdown_height

I guess I've never bootstrapped dvl-core on this computer... I'm running into installation issues with capybara-webkit. I'll assign this to @vlymar for review once I straighten that out.

vlymar commented 7 years ago

let me know if you need help getting capybara-webkit running

vlymar commented 7 years ago

@jrubenoff when i try this out locally, I see the new spacing between the click target and the menu, but the menu doesn't cut off in the middle of the menu item.

jrubenoff commented 7 years ago

You're right. Just re-adjusted.

vlymar commented 7 years ago

once you merge this, i'l bump our bundle and redeploy screendoor