search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Switch from capybara-webkit to poltergeist for specs. #305

Closed vlymar closed 7 years ago

vlymar commented 7 years ago

capybara-webkit depends on QT, which is a nightmare.

See https://github.com/dobtco/our-boxen/issues/21#issuecomment-282429635 for more info.

vlymar commented 7 years ago

trying to understand if https://percy.io/dobtco/dvl-core/builds/278910?snapshot=8679699 is actually a problem or not. As far as I can tell it just seems like poltergeist renders the dropdown a bit less wide than capybara webkit, which doesn't seem like a real problem.

jrubenoff commented 7 years ago

…Yeah, I feel like that’s OK

On Thu, Jul 6, 2017 at 4:33 PM, Victor Lymar notifications@github.com wrote:

trying to understand if https://percy.io/dobtco/dvl- core/builds/278910?snapshot=8679699 is actually a problem or not. As far as I can tell it just seems like poltergeist renders the dropdown a bit less wide than capybara webkit, which doesn't seem like a real problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dobtco/dvl-core/pull/305#issuecomment-313547371, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRG0Q1Wfzgmpqaym2RuIaJDNWxtEkpTks5sLW7WgaJpZM4OQOAW .

vlymar commented 7 years ago

@drusepth, just wanted to explain what was going on here.

We used to use capybara-webkit as our capybara driver (its basically a headless browser). capybara-webkit depends on QT, which is sorta a nightmarish dependency that has gotten more and more difficult to support, particularly on macOS. Adam had already started using poltergeist (backed by phantomJS) in screendoor , so I decided to just move everything else to poltergeist as well, which allows us to remove the QT dependency from our dev environment.

This was a repo I missed, so when Josh tried to bundle here recently it failed.

You can ignore the percy failure, it looks like just a minor difference between how the dropdown is rendered between QT and phantom. Also disregard all my intermediate commits.

js_errors: false matches the previous behavior capybara-webkit

vlymar commented 7 years ago

just looking for a quick sanity check here, dont think this is worth deep thought

vlymar commented 7 years ago

This was a minor enough change that i didn't think it needed review.