CircleCI 2.0 - Githubissues

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

CircleCI 2.0 #306

Closed talgie-cb closed 6 years ago

talgie-cb commented 6 years ago

Description

Convert this repo's Circle CI config to v2.0

Changes

[x] building successfully
[x] tests passing https://circleci.com/gh/dobtco/dvl-core/1062
[ ] deploys working

Issues:

This uses circleci's ruby 2.3.7 image. Without building our own docker container, this means that dvl-core now requires 2.3.7 to run on circleci. We should consider moving everything to 2.3.7 now considering that's what CI tests are using.

Github issue

c.f. https://github.com/dobtco/dobt/issues/2387

talgie-cb commented 6 years ago

I had originally intended on cherry picking commits so some of the less formal messages would disappear. I can still do this if anyone would like me to.

kariannemah commented 6 years ago

@talgie-cb No need to cherry pick. We tend to squash and merge PRs anyways.