search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Add .sub_label #32

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

Fixes dobtco/screendoor-v2#1228

ajb commented 9 years ago

Can you add some markup to the forms.rb page, too?

jrubenoff commented 9 years ago

Done

ajb commented 9 years ago

Sorry, I coulda just waited for the associated PRs. Looks great, I'll review in a bit

On Mon, Jan 12, 2015 at 4:02 PM, Josh Rubenoff notifications@github.com wrote:

Done

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/pull/32#issuecomment-69645239.

Adam Becker (951) 9-BECKER @AdamJacobBecker

ajb commented 9 years ago

This PR looks great, but it's not going to be entirely necessary, since formrenderer-base has now been changed to use the .fr_sub_label class. I know the dependency stuff can get confusing, but our dependency graph looks like this:

img

So theoretically, dvl-core should not even know about formrenderer-base. We can certainly merge this PR since the styles look handy, but we'll still need to add the styles to Screendoor's formrenderer overrides.

jrubenoff commented 9 years ago

Let's just ditch this PR, then.