search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Fix for #30 #33

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

Change .dropdown_toggle_button to display: block;

ajb commented 9 years ago

Err, isn't this side-effect kinda drastic?

img

I've fixed this in a commit, not sure if will have unintended side-effects or not...

ajb commented 9 years ago

Also, a friendly reminder about commit/PR messages :)

ajb commented 9 years ago

Are these CSS tweaks for formrenderer, or Screendoor?

  1. You'll notice that for better or worse, formrenderer uses px values in its CSS. I'd like to either stick with this, or rework the entire file to use rem or em units.
  2. There's a layout error here, which is why I was using absolute positioning:

img

ajb commented 9 years ago

Can you follow-up?

jrubenoff commented 9 years ago

I think dobtco/formrenderer-base#24 should take care of this.