@jrubenoff: I don't think this needs a ton of feedback, but I wanted to run it by you first. It should go without saying, but this PR doesn't mean that I'm going to change any existing apps without approval, too -- e.g. I'm not going to modify dobtco/splash just because I've made some changes here.
Anyway, checkout this branch and run script/server to see the updated docs site (still a WIP). Not much has changed (we should be able to update inside of Screendoor without any side-effects), but I've tweaked the structure of this repo a little bit and I'm pretty happy with where it turned out:
dvl/core is a manifest for the base styles that we'll need for every project. These styles are designed to be overridden with SCSS variables -- see here for an example
dvl/app contains a bunch more common "app" components, like modals, tooltips, dropdowns, progress bars, etc...
As for the grid, I've modified our current grid to inherit from @mixins, and I've added some @push mixins since you had them in your grid. Our grids work a little differently, but the existing one is tried and true IMO.
The goal with all of this was to make it really clear which styles are "app" styles and which styles are necessary for default elements to "look right".
Remember how I thought we had "app" styles and "splash" styles? Turns out they can both inherit from the same base, as long as that base is overridable.
@jrubenoff: I don't think this needs a ton of feedback, but I wanted to run it by you first. It should go without saying, but this PR doesn't mean that I'm going to change any existing apps without approval, too -- e.g. I'm not going to modify
dobtco/splashjust because I've made some changes here.Anyway, checkout this branch and run
script/serverto see the updated docs site (still a WIP). Not much has changed (we should be able to update inside of Screendoor without any side-effects), but I've tweaked the structure of this repo a little bit and I'm pretty happy with where it turned out:dvl/coreis a manifest for thebase stylesthat we'll need for every project. These styles are designed to be overridden with SCSS variables -- see here for an exampledvl/appcontains a bunch more common "app" components, like modals, tooltips, dropdowns, progress bars, etc...@mixins, and I've added some@pushmixins since you had them in your grid. Our grids work a little differently, but the existing one is tried and true IMO.The goal with all of this was to make it really clear which styles are "app" styles and which styles are necessary for default elements to "look right".
Remember how I thought we had "app" styles and "splash" styles? Turns out they can both inherit from the same base, as long as that base is overridable.
LMK if you have questions.