dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Redesign / standardize component library #54

Closed jrubenoff closed 9 years ago

jrubenoff commented 9 years ago

https://redpen.io/p/pfe9a6dcd0fcddf8ca

Spent a few hours on this today. I'll keep chipping away at it on the side...

ajb commented 9 years ago

I really like this direction. I figure we can incrementally move all of our components over to this visual style like we've already been doing a little bit?

On Wed, Mar 11, 2015 at 8:55 PM, Josh Rubenoff notifications@github.com wrote:

https://redpen.io/p/pfe9a6dcd0fcddf8ca

Spent a few hours on this today. I'll keep chipping away at it on the side...

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/issues/54#issuecomment-78405006.

Adam Becker (951) 9-BECKER @AdamJacobBecker

jrubenoff commented 9 years ago

Might make sense to try converting other apps (Opener, knowledge base, the blog) to this style before Screendoor. Low-risk way of finding out what we're missing.

jkgoldst commented 9 years ago

big improvement!

On Wed, Mar 11, 2015 at 6:21 PM, Josh Rubenoff notifications@github.com wrote:

Might make sense to try converting other apps (Opener, knowledge base, the blog) to this style before Screendoor. Low-risk way of finding out what we're missing.

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/issues/54#issuecomment-78407338.

Josh Goldstein CEO, Department of Better Technology (dobt.co)

ajb commented 9 years ago

Might make sense to try converting other apps (Opener, knowledge base, the blog) to this style before Screendoor. Low-risk way of finding out what we're missing.

Not sure I follow, what I'm advocating for is more of what I just did for the navbar, which doesn't seem like it carries many (if any) risks.

jrubenoff commented 9 years ago

Sure. We need to be mindful of the order in which we tackle it, I think. Just changing core styles, or changing a component while leaving everything around it untouched, might look weird by itself.

Did some more last night: https://redpen.io/p/pfe9a6dcd0fcddf8ca

To-do list to give you an idea of scope:

screen shot 2015-03-12 at 11 56 58 am