remove dropdown toggle button

[ajb]

Closes https://github.com/dobtco/dvl-core/issues/72.

Before

After

@jrubenoff, am I overlooking anything? I think the "before" looks better, but "after" makes a lot more sense, since these are buttons, not <select>s.

For reference, this is the main place they'll be used:

[jrubenoff]

Can you clarify why you made this change? They weren't selects before. Also, if they're buttons, why not make them <button> tags?

Also note that I plan to change the styling again later this week: https://dobt.wake.io/184

[ajb]

Sorry, I didn't realize that it wasn't as obvious to others. We can make them button tags, yes, since the .button class doesn't care.

The problem with .dropdown_toggle_button is that it was often used next to a .button, but the height wouldn't match up. It seemed like a really weird pattern that if we still need it, should just be a modifier of .button.

On Mon, Apr 13, 2015 at 6:53 PM, Josh Rubenoff notifications@github.com wrote:

Can you clarify why you made this change? They weren't selects before. Also, if they're buttons, why not make them tags?

Also note that I plan to change the styling again later this week: https://dobt.wake.io/184

— Reply to this email directly or view it on GitHub https://github.com/dobtco/dvl-core/pull/73#issuecomment-92524623.

Adam Becker (951) 9-BECKER @AdamJacobBecker

[jrubenoff]

Alright. LGTM for now!

[ajb]

Thanks -- hrm, I'm just feeling weird that I'm actively making elements look worse. Maybe I should add a modifier to the button, like .is_toggle, that restores some of the style?

[jrubenoff]

Sure... maybe add back the border and background color?

[ajb]

:+1: