search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

New modals, dl #8

Closed ajb closed 9 years ago

ajb commented 9 years ago

@jrubenoff: I'm a little concerned about the changes to dl, since we use it in a lot of places throughout Screendoor. Have you considered all of the possible repercussions of this change?

img

ajb commented 9 years ago

.modal_confirm should probably have a light-colored close button

img

ajb commented 9 years ago

I'm also concerned that .modal_header will look weird now next to the now-used .modal_footer, since the header has less height than the footer. Thoughts?

jrubenoff commented 9 years ago

I'm good with the dls! Added a bit more padding to .page_subheader, but the other pages I took a look at (message preview, imports, etc.) seem OK.

.modal_confirm should probably have a light-colored close button

Done.

I'm also concerned that .modal_header will look weird now next to the now-used .modal_footer

Eh, it's a little odd, but good enough to merge for now, I think.

ajb commented 9 years ago

Awesome. I'll merge and then add the Modal Erector component to this repo, too. (Currently the styles are in here, but the Erector component is still in Screendoor... whoops!)