search

dobtco / dvl-core

Base styles for the DOBT View Layer.
https://design.dobt.co/
1 stars 1 forks source link

Platform changes #85

Closed aviv closed 9 years ago

aviv commented 9 years ago

extract some components from screendoor for use on platform.

aviv commented 9 years ago

Should I add an example for data_simple?

ajb commented 9 years ago

Yes, everything that's inside of dvl-core should have an associated example.

aviv commented 9 years ago

OK, data_simple actually isn't working that well in platform, so I just removed it. Don't think it really needs to be in dvl-core.

aviv commented 9 years ago

OK, sorry about that; I think I assumed too much about those components. Now I'm just adding the page_header component, which I modified to include page_subheader and secondary/tertiary_nav-- let me know if this is cool, or if you want them separated out.

aviv commented 9 years ago

BEM was helpful, this look OK?

ajb commented 9 years ago

Awesome! This looks great. I still need to test it out (I've only looked at the code so far), but I'll make sure it gets merged this week.

ajb commented 9 years ago

Made some more changes. Next time, just make a comment in here that you want me to preserve the pre-rebase history and I'll do it; I just had to delete your pre-rebase branch since I wasn't done making changes.

aviv commented 9 years ago

✅