Add more page header styles

dobtco / dvl-core

Base styles for the DOBT View Layer.

https://design.dobt.co/

1 stars 1 forks source link

Add more page header styles #91

Closed ajb closed 9 years ago

ajb commented 9 years ago

These are needed for the platform redesign as well as the new "View project" button inside of Screendoor.

.page_header_multiline (http://take.ms/dJZnY)
.with_back_arrow (http://take.ms/onNBR)
.page_header_button (http://take.ms/fbWWE)

These haven't been tested cross-browser, and the .page_header_button uses some hacks and a float order that makes me a little uncomfortable.

I thought it would be helpful to centralize our work inside of this PR in dvl-core, though.

jrubenoff commented 9 years ago

Best practices here are to create container divs for multiple elements aligned to one side, so that's what I did.

Will this affect any other repos besides platform and Screendoor?

ajb commented 9 years ago

Were you looking at http://dvlcore.dev/navigation while developing this? It looks out-of-sync.

page_header_multiline is not doing anything. Do we still have a multiline and single-line header component, or are all of our page headers multiline?
the "Page Header with button and back arrow" preview didn't include a .secondary_nav. I just added it, and now it looks weird IMO:

Can you take a less-rushed look at this? I don't feel comfortable merging because of the sloppiness.

jrubenoff commented 9 years ago

All page headers are now multiline. Where is .page_header_multiline supposed to appear? It seems to be added before this PR... I thought we were using it somewhere I wasn't aware of, so I didn't touch it.

I tested the back arrow header with secondary navigation before committing and it looked fine to me. The arrow shouldn't be aligned with the navigation... you're going back from the page described by the title.

jrubenoff commented 9 years ago

And yes, I was looking at /navigation... is there another page I should be aware of?

ajb commented 9 years ago

Where is .page_header_multiline supposed to appear? It seems to be added before this PR

No, it was added in this PR, in this commit: https://github.com/dobtco/dvl-core/commit/a450862b15f293565016353e0e4bb6fc1092799b

And yes, I was looking at /navigation... is there another page I should be aware of?

Nope, that's it. I apologize, it didn't seem like you were aware of it, since there were a couple of classes that were left in the CSS but no longer used.

This is what looks weird to me -- I think the tertiary ul should be aligned to the bottom:

This already happens when the page title is super long:

jrubenoff commented 9 years ago

Ahhh, weird. It's not showing up in the overall diff comparison.

Just committed.

ajb commented 9 years ago

Yeah, I removed it so it wasn't showing up.

Anyway, looks great, thanks! Merging.