dobtco / gbas

https://staging.hhs-gbas.org
0 stars 0 forks source link

Exclude days from scheduling period #24

Closed jrubenoff closed 8 years ago

jrubenoff commented 8 years ago

Outcome

When an office has a holiday, training day, or other "off day", allow admins to prevent adding time slots during those days.

Structure

To consider: the Doodle has interview days starting at different times, so they might want to exclude individual timeslots as well.

Interaction

TBD

Breaking this out from #12

ajb commented 8 years ago

(Feel free to move this to another issue or thread.)

Another thing to consider is that if we immediately send availability requests upon submitting the "Schedule" step of the configuration wizard, we'll need to allow admins to customize the schedule by manually adding and removing timeslots in order to ensure that our app works for projects with alternate or non-repeating schedules.

i.e. if an admin wants to add two timeslots on Thursday before asking for availability, how would they do that?

ajb commented 8 years ago
jrubenoff commented 8 years ago

ensure that our app works for projects with alternate or non-repeating schedules

I was assuming this would be out of scope!

if an admin wants to add two timeslots on Thursday before asking for availability, how would they do that?

If admins add timeslots immediately after sending out invites, that seems like it solves the problem. The only downside is that candidates / staff who click on the invite immediately after it goes out (which seems unlikely?) won't see those two timeslots.

ajb commented 8 years ago

I was assuming this would be out of scope!

:+1: on moving it to v2 (or never, if nobody asks for it,) but let's ensure that this isn't necessary for GBAS.

Remember, in their Doodle, there were slightly different times on each day.

If admins add timeslots immediately after sending out invites, that seems like it solves the problem. The only downside is that candidates / staff who click on the invite immediately after it goes out (which seems unlikely?) won't see those two timeslots.

Sure, or we can delay the invites by ~10 minutes or so, and explain in the UI that they should tweak their timeslots immediately?

I'm worried about:

...because now, the autobook is going to fail pretty miserably.

jrubenoff commented 8 years ago

That seems like an edge case? I'm not convinced that trying to solve it is worth sacrificing the wizard's current simplicity.

If what you describe ends up being a common problem, we can always amend the wizard later.

jrubenoff commented 8 years ago

Interaction

Here's the default state:

screen shot 2016-08-01 at 10 49 27 am

If you select "except for the days...", here's what you see.

Any days before and after the start date are disabled in the datepicker. The admin also said they wanted interviews from Monday to Friday, so Saturdays and Sundays are disabled.

Here's what it looks like if the user presses "Add a day." (Aside: that button's copy isn't great. Maybe I'll rename to "Exclude another day"?)

Since April 18 was selected earlier, it is disabled in the datepicker for subsequent days. If multiple days are excluded, the admin can press the "X" to stop excluding a given day.

ajb commented 8 years ago

This issue was moved to dobtco/scheduler#12