search

doc-ai / tensorio-android

TensorIO for Android
2 stars 6 forks source link

First version of pytorch inference support #188

Closed SamLeroux closed 3 years ago

phildow commented 3 years ago

@SamLeroux this looks amazing! I've gone through the code on GitHub and it looks like you picked up the patterns I'm using for the tf implementations nicely.

I'm going to go ahead and merge it but into a different dev-pytorch branch so I can have a look at it locally off dev. If I make any changes I'll push back up to that branch and PR it so you can see what I modified.

phildow commented 3 years ago

@SamLeroux First thing I notice:

When adding tests and assets for tests, add them to an androidTest folder in the module rather than main or test folder, and then use the testContext rather than the appContext in the integration tests.

The difference is that assets in the main folder will be embedded with the module when it is deployed via JitPack and consequently show up as assets in whatever project has it as a dependency. Assets in the androidTest folder will not.

I first noticed this with NetRunner, which would scan its assets directory for embedded tiobundles. We only wanted the application's tiobundles to be included, but all the tiobundles from the tensor/io tests were showing up as well. Moving them out of main and into androidAssets fixed that.

phildow commented 3 years ago

@SamLeroux I'll be pr'ing from here: https://github.com/doc-ai/tensorio-android/pull/192