search

doc-bok / Butterflies

Adds pretty butterflies to the world.
https://www.bokmcdok.com
MIT License
4 stars 1 forks source link

Invisible butterflies on servers #103

Closed mxnmnm closed 6 months ago

mxnmnm commented 6 months ago

I need to do more testing but it seems that butterflies end up being invisible on servers but not singleplayer. I'm not sure if this is a mod interaction or not so I'll test it out but if you have any ideas of what might be causing this a fix would be great. Otherwise I'll come back here and tell you what issues/info I find. Figured I should let you know this does seem to be a problem.

mxnmnm commented 6 months ago

This is not an issue with any other mods as it occurs with only this mod installed. So I hope you can find a fix.

mxnmnm commented 6 months ago

This seems to have been an issue first introduced in version 2.1.1

doc-bok commented 6 months ago

Oh wow, this is the best kind of bug report - nailed it down to the specific change :)

That was the change that fixed invisible caterpillars. Is there any chance you could test caterpillars as well, see if they're invisible on servers? There should be caterpillar spawn eggs you can use.

Hopefully this will be an easy fix.

mxnmnm commented 6 months ago

Oh yea it does it for all mobs in this mod

doc-bok commented 6 months ago

Okay, that means reverting the original change is the fix. That brings back the original invisible caterpillars issue though, unfortunately.

mxnmnm commented 6 months ago

Will there be another way to fix the caterpillar issue?

doc-bok commented 6 months ago

I'm not sure. I'm trying to reproduce this one locally to see if I can understand what's going on and develop a better fix.

doc-bok commented 6 months ago

Okay, I have managed to reproduce it and I think I know what the problem is. I had a fundamental misunderstanding of how things work :/

I should be able to fix this properly today. Just need to come up with a good solution.

mxnmnm commented 6 months ago

Yay gl finding a fix :)

doc-bok commented 6 months ago

Well that one was a doozy, but on the plus side I learned a lot about how networking works in Minecraft. It's fixed now, but I want to take a look at your other bug before I do another release. If I can fix it quickly then it's worth including both fixes.