search

doc-suse-com / site

Issue Tracker for documentation.suse.com
https://github.com/SUSEdoc/documentation.suse.com-issues/issues
5 stars 0 forks source link

#redirectmsg is hidden by default #11

Closed ghost closed 5 years ago

ghost commented 5 years ago

To actually see the #redirectmsg, you need to scroll up which is rather suboptimal.

asettle commented 5 years ago

Yeahhh - Frank and I just spoke about it. Kinda sad. I would recommend a slight update to the message that says we are working on proper redirects, but they will take some time. Or something to that affect.

ghost commented 5 years ago

I don't think we're working on proper redirects, the work involved would be insane... or are we working on redirecting everything now, @fsundermeyer ?

asettle commented 5 years ago

I don't think we're working on proper redirects... or are we?

I'll forward you the email from Matt. Perhaps I misunderstood.

ghost commented 5 years ago

Had that one already but thanks, I think you're misunderstanding it though, afaict.

asettle commented 5 years ago

Superb. That's not so great.

fsundermeyer commented 5 years ago

Redirecting everything is not possible.

fsundermeyer commented 5 years ago

@sknorr The redirect message you get when accessing a /+redirectmsg link is hidden, because the page is opened with the headline in focus. You have to scroll up to see the message. Any idea where I need to look to place the message undermeath the headline?

ghost commented 5 years ago

The issue is a bit more tricky, if you add #anything to the URL, the browser will scroll the page, so #anything is at the top of the screen. Unfortunately, the page header overlays the top of the screen.

However, we could just change the ID of the actual message, so we don't actually scroll to it. To do that without too much fuss right now:

  1. in [docserv-config]/template-external/res/generatebreadcrumbs.js, replace line 27 with the following two lines:

      document.getElementById('redirectmsg').id = 'redirect_message';
  document.getElementById('redirect_message').style.display = '';

  2. Then rebuild something simple like sle-vmdp,2.5,en-us.

This renames the ID before the message is made visible. You could also change the message ID directly in the template HTML files but that would mean you'd have to run a regex on all the existing HTML navigation files or rebuild the entire site yet again. So don't do that.

ghost commented 5 years ago

Will be fixed on short order.