docToolchain / docToolchain

a AsciiDoc Toolchain for technical Software Documentation, focused on Software Architecture Documentation
https://doctoolchain.github.io/docToolchain/
MIT License
723 stars 226 forks source link

fix loading of custom ruby extensions #1364

Closed PacoVK closed 4 months ago

PacoVK commented 4 months ago

This will fix #1290 #1239 and also complete the performance issue described in #1353

This PR moves the setting rubyExtensions to the top level and makes it no longer an option within the microsites config. The reason is that it does not relate to micrositetasks since they depend on JBake and JBake currently does not support custom Ruby extensions.

A follow up to this task is #1363 where we should document the config option

All Submissions:

netlify[bot] commented 4 months ago

Deploy Preview for dtc-docs-preview ready!

Name Link
Latest commit 92e6181bc850758f37a177044ed1f0bc40cf618b
Latest deploy log https://app.netlify.com/sites/dtc-docs-preview/deploys/65cc8234920fd10008ca9b67
Deploy Preview https://deploy-preview-1364--dtc-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

PacoVK commented 4 months ago

@rdmueller PTAL if you have time :)

rdmueller commented 4 months ago

Shouldn't we keep the mechanism that the gems are automatically activated when we use reveal?

PacoVK commented 4 months ago

@rdmueller thats what this PR does activate Ruby gems only when actually needed. Otherwise you see dramatic loss of performance in every docToolchain task due to the start of the required Ruby Gem proxy if defined globally...

rdmueller commented 4 months ago

let's merge...