Open phertweck opened 1 year ago
thanx for this contribution. Sorry, that this took me so long to check.
Two suggestions:
Hello. I use a Synology NAS for gitlab and kroki (for the gitlab wiki which supports kroki), both as dockers. I've just added a docToolchain docker image as I intends to use docToolChain for gitlab Pages.
A separate kroki server/docker will be fine for me. Pascal
I agree that adding mmdc increases the image size. I'd also prefer the kroki solution, since mmdc has some strange errors with some of my test diagrams.
Is there an easy solution to configure a kroki server in docToolchain?
I am not sure whether this is a good solution. But i created an other docker-image which has doctoolchain + pandoc. At least it was accepted. :-D
Maybe you you just copy this approach and create the new image with kroki in it. Example can be found in the PR https://github.com/docToolchain/docker-image/pull/38 if you have questions just ask.
I wonder how many images we should maintain. My main goal was to have one small image. I missed this goal by at least 1GB :-)
The pandoc image is not much bigger than the standard image. Should we merge both?
what about mmdc? How much will it add? Would it make sense to add a kroki server instead to support all diagram types?
In the current version the rendering of Mermaid diagrams is not working
In this Pull request the mmdc is installed in the docker image.