search

docToolchain / docker-image

MIT License
2 stars 18 forks source link

Use kroki.io to render diagrams #37

Open phertweck opened 1 year ago

phertweck commented 1 year ago

In context with #31, it would be good to use kroki.io to render diagrams. Especially to support a broader variety of diagram libraries.

00Asgaroth00 commented 1 year ago

+1 It would be great if kroki was an option to use, but, to also make it configurable for using a local instance or and external instance (kroki.io)

I'm currently having an issue generating rackdiag images as the docker container does not appear to have rackdiag/rackdiag3 installed, according to the following message:

> Task :generateHTML
Converting /project/docs/rack_layout.adoc
rack_layout.adoc: line 27: Failed to generate image: Could not find the rackdiag, rackdiag3 executable in PATH; add it to the PATH or specify its location using the rackdiag document attribute
rdmueller commented 1 year ago

Yes, great idea! Anyone ready to create a pull request?

phertweck commented 1 year ago

Unfortunately, I don't have any idea how to configure docToolchain to use an external kroki instance.

rdmueller commented 1 year ago

https://docs-as-co.de/news/diagrams-with-kroki/

but it would be also great to have a kroki instance running inside the docker container. This should be possible with the fat-jar provided by kroki.io

rdmueller commented 1 year ago

see also https://github.com/docToolchain/docToolchain/issues/531