search

docToolchain / docker-image

MIT License
2 stars 18 forks source link

#433 => https://github.com/docToolchain/docToolchain/issues/433 proposal #38

Closed ehmkah closed 1 year ago

ehmkah commented 1 year ago

This is a proposal for fixing https://github.com/docToolchain/docToolchain/issues/433

rdmueller commented 1 year ago

hey, this is great! shouldn't we deploy this image to the doctoolchain-dockerhub space the same way as the other images?

ehmkah commented 1 year ago

Yes - because than its "find - and useable" for me and others :-)

Should I remove the buildscript because it contains my docker-hub name? For me those building-scripts are somehow easier to handle than copy-paste from Readme files.

Or are there any other changes required?

rdmueller commented 1 year ago

I think the main missing point is a github action workflow https://github.com/docToolchain/docker-image/tree/ng-beta/.github/workflows

I know these workflows are quite complex and I am currently not sure where to add your image in the workflow.

Any ideas?

ehmkah commented 1 year ago

OK - I always wanted to learn something about those git-actions. It looks like the time has come.

One remaining question for me is whether I could leave the base image as doctoolchain/doctoolchain:v2.1.0 or whether the pandoc step should be added to the alpine image as an extra step.

rdmueller commented 1 year ago

good question. you decide!

ehmkah commented 1 year ago

i updated my fork so the base doctoolchain is building. I copied the content of the doctoolchain-build and added the pandoc instructions into it. Also there is this github build action.

I hope this is fine for the moment.

rdmueller commented 1 year ago

Great! Let's build the image!

ehmkah commented 1 year ago

Thank you also pushing it to docker-hub

https://hub.docker.com/r/doctoolchain/doctoolchain-with-pandoc

rdmueller commented 1 year ago

should we add this somewhere to the docs?

ehmkah commented 1 year ago

yes. i am unsure where to put it. https://github.com/docToolchain/docker-image/blob/ng-beta/README.md would be my first choice. That might also be a good starting for describing the differneces between the available images.

Or where is your favorite place?

rdmueller commented 1 year ago

I guess the README is a good choice. And we should link to it somewhere from the main docToolchain documentation, shouldn't we?

ehmkah commented 1 year ago

https://github.com/docToolchain/docker-image/pull/41 => i am unsure what the jenkins and the azure docker-image are useful for.

ehmkah commented 1 year ago

I wanted to link official documentation to this docker-image readme, but i do not see a good place to put. First try was 120_self-contained-dtc.adoc but this is somehow about self containing dtc - any ideas?