docb / dbRackModules

GNU General Public License v3.0
15 stars 1 forks source link

RndG Prob input issue #14

Closed firolightfog closed 2 years ago

firolightfog commented 2 years ago

I believe that the Prob input of RndG is messed up some very strange way. Or I am.

Feeding 5V to Prob I'd expect to see 100% of the pulses. (See purple signal.)

image
docb commented 2 years ago

hi Andras, i think this behaves correct:

the trig output only fires if the gate goes from 0 to 10. if you set prop to 100% the gate stays at 10V and no trig will come.

rgate2

the clock output will fire as long the gate is 10V. best regards, Christian

firolightfog commented 2 years ago

I'm closing the case. I can't recreate my original error. I don't know how I did it.

Checked again and everything works as it should.

image
firolightfog commented 2 years ago

I'm reopening the ticket. Something is not right with this module.

In my previous test I sent the same signal to all channels and I saw some variation in the Clk output. (In my original bug report I checked the Trig output.)

But if I send various rhythms on the poly channels and a Prob input is provided (e.g. 5V for 100%) then

image

Regards, Andras

docb commented 2 years ago

hi Andras, the clock input is definitely monophonic currently. sorry, i didn't have had a usecase for a polyphonic clock input so I didn't implement it yet. But i think it is doable for the next version. best regards, Christian

docb commented 2 years ago

hi Andras, here is a dev version which fixes #11 #12 #14

https://github.com/docb/dbRackModules/releases/tag/2.0.5-dev-1

best regards, Christian

firolightfog commented 2 years ago

Some truly wonderful and important improvements! Seeing the quick tests below I'd encourage you to promote this version to the Library. However I'm still confused what to expect from the Trg output of RndG.

11 RndC, RndH, RndG panel improvements look great

12 RndG Clk output PW is fixed for common clock inputs and works great

image

14 RndG Prob input works nicely with poly input signal

image

14 RndG Prob handles easily if the number of channels in poly input is different from the RndG Chn settings

image

14 RndG Clk doesn't repeat the first channel for polyphonic output but handles the poly input of Clk nicely

image

This is great! Thank you Christian!

Cheers, A.

docb commented 2 years ago

hi Andras, thanks for verifying. to verify the correctness of the trig output you always have to compare the trig output with the gate output. the trig output fires if the gate goes from 0 to 10. the clock outputs the clock input iff the gate is 10V. note that LA-108 and LA-216 do not show triggers correctly - there are always missing triggers - the gate must be made longer for correct results. look at this: the top line direct and the bottom line with lengthen gates:

la-216

however still here is a trigger missing. but i don't trust the LA-216 ... best regards, Christian

firolightfog commented 2 years ago

I got it now. You are right with the trigger and the analyzer... RndG seems to be working perfectly. :)

image

I think all #11, #12, #14 can be closed with the docB v2.0.5 release.

Best regards, Andras

docb commented 2 years ago

Solved