docb / dbRackSequencer

GNU General Public License v3.0
18 stars 6 forks source link

Crashing the Matrix #2

Closed firolightfog closed 2 years ago

firolightfog commented 2 years ago

I'm fooling around with the Matrix. This setup crashed my VCV Rack 2.0.6 under Win.

image
docb commented 2 years ago

hi, cannot reproduce. could you provide the logs?

docb commented 2 years ago

but i found a possible problem (and fixed it for the next version). could you please try the following workaround: disconnect channel 2-4. and then connect to CvX. and then reconnect channel 2-4.

firolightfog commented 2 years ago

I couldn't see anything in the log.txt:

[3.194 info src/app/RackWidget.cpp:366 fromJson] Creating module widget dbRackSequencer TheMatrix [3.196 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/TheMatrix.svg [3.197 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/RButton0.svg [3.197 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/RButton1.svg [3.197 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/SmallPort.svg [3.197 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/TrimpotWhite.svg [3.197 info src/app/RackWidget.cpp:366 fromJson] Creating module widget VCV LFO [3.198 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/Fundamental/res/LFO.svg [3.198 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/RoundHugeBlackKnob.svg [3.199 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/RoundHugeBlackKnob_bg.svg [3.199 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/Trimpot.svg [3.199 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/Trimpot_bg.svg [3.199 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/VCVButton_0.svg [3.199 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/VCVButton_1.svg [3.199 info src/app/RackWidget.cpp:366 fromJson] Creating module widget VCV VCO [3.200 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/Fundamental/res/VCO.svg [3.200 info src/app/RackWidget.cpp:366 fromJson] Creating module widget VCV Merge [3.201 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/Documents/Rack2/plugins/Fundamental/res/Merge.svg [3.201 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/Plug.svg [3.201 info src/window/Svg.cpp:28 loadFile] Loaded SVG C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/ComponentLibrary/PlugPort.svg [3.201 info adapters/standalone.cpp:238 main] Running window [3.235 info src/window/Window.cpp:50 loadFile] Loaded font C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/fonts/DSEG7ClassicMini-BoldItalic.ttf [3.235 info src/window/Window.cpp:50 loadFile] Loaded font C:/Users/aszabo/Documents/Rack2/plugins/ImpromptuModular/res/fonts/Segment14.ttf [3.236 info src/window/Window.cpp:50 loadFile] Loaded font C:/Users/aszabo/OneDrive - UNICEF/private/DAW/Rack2Free/res/fonts/ShareTechMono-Regular.ttf [3.236 info src/window/Window.cpp:50 loadFile] Loaded font C:/Users/aszabo/Documents/Rack2/plugins/dbRackSequencer/res/FreeMonoBold.ttf [4.692 info src/network.cpp:147 requestJson] Requesting JSON GET https://api.vcvrack.com/version?edition=Free


This one looks OK:

image

But this step would crash it for me:

image

Thi step is also deadly:

image

Just for benchmarking all these seem to work fine:

image image image
docb commented 2 years ago

ok, then my fix should work, if you can build it is committed on the main branch already

docb commented 2 years ago

another question: if you have connected e.g. RndC then disconnect, and then connect the Merge, does this crash?

firolightfog commented 2 years ago

I'm afraid I won't be able to build the latest code.

Disconnecting RndC and connecting Merge works fine

image

Same here

image

I hope you see what's going on because I'm puzzled.

Regards, A.

docb commented 2 years ago

yes the fix i have made should work.

docb commented 2 years ago

hi there is a new pre release, could you please check if the crash is gone? thx.

firolightfog commented 2 years ago

Works like a charm. I'm closing the ticket as I can't re-create the crash. Best regards, Andras