docchula / el-player

Docchula Video Player for MDCU E-Learning v2
https://player.docchula.com
Other
0 stars 2 forks source link

fix: dark mode inconsistency #2

Closed ittipatken closed 1 year ago

ittipatken commented 1 year ago

Not sure if this is intentional but when submitting a link, it switches on dark mode. Additional changes

keenthekeen commented 1 year ago

That's intentional.

When the video plays, the surroundings will be dimmed, like in a theater.

ittipatken commented 1 year ago

Thank you for the clarification. Is there any plan to include a toggle switch for permanent dark mode?

keenthekeen commented 1 year ago

Not yet. That's interesting though.

I may implement that using localStorage API by saving user's preference when they manually toggle light/dark theme. A pull request of this feature will be welcomed.