Edit Game Command does not work

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Select Edit Game Command from the context menu on a specific game
2. add some arguments (example -m)
3. launch the game

What is the expected output? What do you see instead?
I expect the game to be launched with the appended commands, what happens is 
these command get disregarded.

What version of the product are you using? On what operating system?
0.9.7 tested on XBMX Live 10.1 and XBMC 10.1 “Dharma” on Windows XP Pro

Please provide any additional information below.
According to the log file, the commands are being saved but just not added to 
the game command line.  I've attached the windows xp xbmc log as this is the 
last one I tested and the error appears the same in both Live and XP.  If you 
also need XBMC Live log let me know.

Original issue reported on code.google.com by norman.l...@googlemail.com on 5 Jan 2012 at 12:30

Attachments:

• xbmc.log

[GoogleCodeExporter]

Did you use the placeholder %GAMECMD% in your emu params like explained here: 
http://code.google.com/p/romcollectionbrowser/wiki/EditRomCollectionLaunchGames#
Emulator_Params?

Original comment by maloep on 7 Jan 2012 at 8:59

[GoogleCodeExporter]

Ah, no I didn't do that.  After looking through your wiki again and then how 
this feature works in RCB, can I suggest that it be implemented differently ?  
I don't think you current method is very intuitive.  If %GAMECMD% is always in 
the emu params as default and If there are no game commands supplied then it 
will make no difference.  So that way if game commands are supplied by the 
user, they are automatically added without having to add %GAMECMD% to the emu 
params.  Would this way not work more intuitively and easier for the average 
user (like me lol) maybe ?

If manually inserting %GAMECMD% to the emu params is preferred, maybe due to 
customizing the order of which the commands are passed to the emulator, then 
this could be overcome by simply still allowing the %GAMECMD% to be entered in 
emu params.  This could overwrite/replace the default %GAMECMD% which for 
example could always be passed straight after the emulator program by default.  
I hope you understand what I mean.

If you'd prefer a new issue (enhancement?) then I'll do that instead of keeping 
this issue open ?

Original comment by norman.l...@googlemail.com on 7 Jan 2012 at 11:53

[GoogleCodeExporter]

You already name the order of the commands. This is the reason why I decided to 
implement it the way it is now. If I would add the command by default like you 
suggested, where do you think would most users need it? At the beginning or at 
the end of the command or before/after the rom name? Sometimes it does not 
matter but a lot of emulators are not really forgiving if the order of 
parameters is wrong.

So in my oppinion it will be better to leave it the way it is. Or you have 
other arguments to convince me:)

Original comment by maloep on 8 Jan 2012 at 12:38

[GoogleCodeExporter]

Well so far, all emulators I've tried use the gamecmd before the rom (I guess 
there will be some out there that take it after).  So in this regard, the 
beginning would be fine for most.  And like I said, if a user wants to change 
the order then they simple add the %GAMECMD% wherever it is needed in the emu 
params incase it's needed after rom name.  That way it works best of both 
worlds.  As most emulators accept game commands before the rom name and I 
assume most users would find it easier just adding the one game command, then 
this would be a more viable solution?

If you are still not convinced then how about a complete redo of the way the 
gamecmd works ?  I know for something so simple this is a bit drastic but; how 
about when pressing "enter game command" this would bring up the whole of the 
pre determined game command from the emu command, and then allow you to insert 
your custom game command for that specific game.  Thus showing you the whole of 
what will be passed to the emulator for that specific game ? i.e. pressing 
enter game command could bring up THE DIALOG

PLEASE ENTER GAMECMD WHERE NEEDED  <-- title ?
('uae -f customgame.uae -0 gamedisk.adf'   <-- editable command string ?

This would definitely improve use-ability in this regard but may be a bit of a 
pain for you to set up.

Either way, I hope you understand what I'm getting at.  And if you disagree, 
then nevermind :) Thanks for listening though, much appreciated.

Original comment by norman.l...@googlemail.com on 8 Jan 2012 at 1:42

[GoogleCodeExporter]

Original comment by maloep on 4 Jul 2012 at 3:32

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by maloep on 22 Dec 2012 at 12:30

• Changed state: WontFix