search

docdoku / docdoku-plm

The project purpose is to develop a comprehensive, robust open source PLM (Product LifeCycle Management) solution.
http://www.docdokuplm.com
GNU Affero General Public License v3.0
241 stars 98 forks source link

[Translation] Is it really a good idea to throw translated exception? #1151

Closed defmsy closed 6 years ago

defmsy commented 6 years ago

Wouldn't it be more practical to throw default exceptions and only when necessary catch them and throw their translated version? It would simplify deeper code by avoiding the necessity to provide locale.

mguimard commented 6 years ago

This is not a good idea now that we have removed remote EJBs. Kind of legacy.. Related to #1134

On Thu, May 24, 2018, 10:15 AM Jean-Luc Mounsamy notifications@github.com wrote:

Wouldn't it be more practical to throw default exceptions and only when necessary catch them and throw their translated version? It would simplify deeper code by avoiding the necessity to provide locale.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/docdoku/docdoku-plm/issues/1151, or mute the thread https://github.com/notifications/unsubscribe-auth/ADDoD2NAAfC2fe1WN7exhdlD1TQ3fBwvks5t1mwdgaJpZM4ULw_h .