search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Removing check against minimum server version #2802

Closed nishanttotla closed 7 years ago

nishanttotla commented 7 years ago

v.Version returned in ServerVersion seems to have stopped returning pure numbers that can be compared. As a result, this check is mostly useless, and is causing tests to fail.

Signed-off-by: Nishant Totla nishanttotla@gmail.com

nishanttotla commented 7 years ago

Possibly something like this is required: https://github.com/aluzzardi/dind/pull/7

nishanttotla commented 7 years ago

Ok, here's the issue:

# time="2017-10-04T23:35:38Z" level=debug msg="Failed to validate pending node: engine 127.0.0.1:5260 is running an unsupported version of Docker Engine. Please upgrade to at least 1.8.0" Addr="127.0.0.1:5260" 
# time="2017-10-04T23:35:38Z" level=debug msg="Failed to validate pending node: engine 127.0.0.1:5259 is running an unsupported version of Docker Engine. Please upgrade to at least 1.8.0" Addr="127.0.0.1:5259"

At first glance, I'm not sure how such an old version is being used, so I'll have to investigate that.

thaJeztah commented 7 years ago

Is this comparing docker version, or API version?

nishanttotla commented 7 years ago

@thaJeztah it seemed to be comparing server version, which I verified by printing out.