search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Modify the way of replacing networkid #2816

Closed panli889 closed 4 years ago

panli889 commented 6 years ago

this will fix https://github.com/docker/swarm/issues/2815

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:panli889/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

panli889 commented 6 years ago

@nishanttotla Thanks for your feedback, I've change the way of replacing network id, how about now?