search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Fail VolumeCreate requests if they fail on any node #2840

Closed wsong closed 6 years ago

wsong commented 6 years ago

Also log failures

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "log_failures" git@github.com:wsong/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

wsong commented 6 years ago

Ping @nishanttotla

wsong commented 6 years ago

This was causing some confusion with third-party volume drivers, where volume creates might succeed on one node but fail on others due to problems with a remote volume driver backend.