search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Update go version and golint import path #2942

Closed thaJeztah closed 5 years ago

thaJeztah commented 5 years ago

closes https://github.com/docker/swarm/pull/2906 closes https://github.com/docker/swarm/pull/2822

thaJeztah commented 5 years ago

Looks like there's some genuine failures;

# github.com/docker/swarm/cluster/swarm [github.com/docker/swarm/cluster/swarm.test]
cluster/swarm/build_test.go:39:15: assignment mismatch: 2 variables but 3 values
cluster/swarm/build_test.go:125:15: assignment mismatch: 2 variables but 3 values
cluster/swarm/build_test.go:164:15: assignment mismatch: 2 variables but 3 values
cluster/swarm/build_test.go:207:15: assignment mismatch: 2 variables but 3 values

Looks like that was introduced in https://github.com/docker/swarm/commit/148a2227bac0c5b45cb2254231955175407b91b0 (https://github.com/docker/swarm/pull/2932)

thaJeztah commented 5 years ago

Yay! Travis is green now 🎉

thaJeztah commented 5 years ago

ping @tonistiigi @dperny @wsong PTAL

thaJeztah commented 5 years ago

Looks like the image used in CI is broken for current versions of docker;

# rm: cannot remove '/var/run/docker.pid': No such file or directory
# rm: cannot remove '/var/run/docker/libcontainerd/docker-containerd.pid': No such file or directory
# rm: cannot remove '/var/run/docker/libcontainerd/docker-containerd.sock': No such file or directory
# WARN[2019-05-07T01:45:29.660926426Z] [!] DON'T BIND ON ANY IP ADDRESS WITHOUT setting --tlsverify IF YOU DON'T KNOW WHAT YOU'RE DOING [!] 

# WARN[2019-05-07T01:45:29.662279898Z] could not change group /var/run/docker.sock to docker: group docker not found 

# failed to start containerd: exec: "containerd": executable file not found in $PATH

Last line is the problem; looks like it doesn't have containerd but does have the old docker-containerd binary;

docker run --rm --entrypoint="" dockerswarm/dind-master ls -la /usr/local/bin/
total 176916
drwxrwsr-x 1 root staff     4096 May  6 21:16 .
drwxrwsr-x 1 root staff     4096 Mar 26 12:00 ..
-rwxr-xr-x 1 root staff 64572249 May  6 21:15 docker
-rwxr-xr-x 1 root staff 30325272 May  6 21:16 docker-containerd
-rwxr-xr-x 1 root staff  4743360 May  6 21:16 docker-containerd-shim
-rwxr-xr-x 1 root staff  2847002 May  6 21:16 docker-proxy
-rwxr-xr-x 1 root staff  8088984 May  6 21:16 docker-runc
-rwxr-xr-x 1 root staff 70564320 May  6 21:16 dockerd
docker run --rm --entrypoint="" dockerswarm/dind-master dockerd --version
Docker version master-dockerproject-2019-05-05, build 619df5a

docker run --rm --entrypoint="" dockerswarm/dind-master docker-containerd --version
containerd github.com/containerd/containerd v1.1.2 468a545b9edcd5932818eb9de8e72413e616e86e

Looks like it's some franken-image, as it contains the latest docker daemon, but a version of containerd that matches docker 18.03