search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Fixing CI/Test #2951

Closed dani-docker closed 4 years ago

dani-docker commented 5 years ago

Currently swarm build uses a swarm image that from this repo/branch https://github.com/aluzzardi/dind/tree/dev However we no longer use the docker- prefix for runc and containerd and that is currently causing the dind image to fail to start the daemon.

In this PR, I moved the Dockerfile to swarm repo and fixed the file names. In addition, test helper function.

cc: @thaJeztah @dperny @thaJeztah : Can you help setting the auto build, once we have an image on hub, I will update jenkins.

Signed-off-by: Dani Louca dani.louca@docker.com

dperny commented 5 years ago

shouldn't the tests now be passing, though?

dani-docker commented 5 years ago

shouldn't the tests now be passing, though?

@dperny unfortunately some tests are still failing and looks like they have been failing for a while. I already root caused 3 and still working on the rest . I will open separate PRs. Forgot to mention; before the image change, everything was failing as dind was not even working