search

docker-archive / classicswarm

Swarm Classic: a container clustering system. Not to be confused with Docker Swarm which is at https://github.com/docker/swarmkit
Apache License 2.0
5.75k stars 1.08k forks source link

Add better OS detection #2961

Closed dperny closed 5 years ago

dperny commented 5 years ago

Adds better detection of the OS type of the engine by getting the supported platforms defined in the manifest and creating an ostype constraint using them.

This is #2959 done the right way.

zsun21 commented 5 years ago

After this fix in, we will enable test TestRunWindowsContainerOnController() and make sure it passes (https://github.com/docker/orca/blob/master/integration/basic/c1_ww1/acceptance_test.go#L165).

dperny commented 5 years ago

It seems I don't actually have write access on this repo...