search

docker-archive / cloud-integration-beta

Docker CLI with ACI integration (beta)
https://www.docker.com
32 stars 14 forks source link

Not able to install the script (install.sh) #39

Open Dminor7 opened 3 years ago

Dminor7 commented 3 years ago

I ran the following given command in the document

curl -L https://raw.githubusercontent.com/docker/aci-integration-beta/main/scripts/install_linux.sh | sh

It gives me below error Checks passed! Downloading CLI... curl: no URL specified! curl: try 'curl --help' or 'curl --manual' for more information

I also tested the given Dockerfile-testInstall It is also giving same error.

I guess the issue is in the below lines


# Download CLI to temporary directory
download_dir=$($sh_c 'mktemp -d')
$sh_c "${download_cmd} ${download_dir}/docker-aci ${DOWNLOAD_URL}"

Might be the variables aren't populating

josh-dix commented 3 years ago

Hi - I was able to fix by modifying line 91 as follows: DOWNLOAD_URL=$(curl -sL ${RELEASE_URL} | grep "browser_download_url.*docker-linux-amd64" | cut -d : -f 2,3) The addition of L to curl options follows the redirect that may have either been added later, or missed due to differences in curl behavior somewhere. I plan to open a PR for the change.

davidluque1 commented 3 years ago

Hi - I was able to fix by modifying line 91 as follows: DOWNLOAD_URL=$(curl -sL ${RELEASE_URL} | grep "browser_download_url.*docker-linux-amd64" | cut -d : -f 2,3) The addition of L to curl options follows the redirect that may have either been added later, or missed due to differences in curl behavior somewhere. I plan to open a PR for the change.

This did not fix it for me. Error still appears. Printed $DOWNLOAD_URL and it is empty